-
-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support of FIDO2 credential creation #2814
Conversation
8ea451a
to
641d3fc
Compare
This looks great, but I'll need a bit more time for a proper review. I have some knowledge gaps wrt. passkeys that I want to close first. |
641d3fc
to
dc4971b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. Thank you!
This is a great start! As mentioned, I think you should tweak it a bit to satisfy Json interfaces instead of using the string type if the client responses and all are meant to be in Json. Also this is lacking parsing / marshalling / unmarshalling logic for the |
0b0eccd
to
5a6abaa
Compare
Signed-off-by: Sylvain Pelissier <sylvain.pelissier@gmail.com>
5a6abaa
to
ea78b1c
Compare
This may help: https://research.kudelskisecurity.com/2024/03/14/passkeys-under-the-hood/ |
So is it already available anyhow for end users? I guess no, because browser plugin does not look to support it right now, but may be I am missing something... |
@dluciv no, this now requires quite some work still: this is the ground work to satisfy requests, but we still need to implement the CTAP2 protocol to answer browsers' requests using the code added in this PR as I understand the flow for FIDO2 authenticators. |
Initial incomplete support of passkeys. The goal is to use the passkey package in gopass-jsonapi.