[bugfix] Replace ~ with user homedir if $GOPASS_HOMEDIR is not set

[ghost]

Fixes #2916

[AnomalRoil]

Mhhh, I think this conflicts with the idea of

gopass/pkg/fsutil/fsutil.go

Lines 40 to 56 in 486c165

	// CleanPath resolves common aliases in a path and cleans it as much as possible.
	func CleanPath(path string) string {
	// Only replace ~ if GOPASS_HOMEDIR is set. In that case we do expect any reference
	// to the users homedir to be replaced by the value of GOPASS_HOMEDIR. This is mainly
	// for testing and experiments. In all other cases we do want to leave ~ as-is.
	if len(path) > 1 && path[:2] == "~/" {
	if hd := os.Getenv("GOPASS_HOMEDIR"); hd != "" {
	return filepath.Clean(hd + path[2:])
	}
	}
	if p, err := filepath.Abs(path); err == nil && !strings.HasPrefix(path, "~") {
	return p
	}
	return filepath.Clean(path)
	}

The idea being that "~" is replaced with $GOPASS_HOMEDIR when it's set instead of $HOME, for testing and dev purposes.
Your change feels like it wouldn't do that for git operations anymore (and I'm surprised our tests are passing since they do use GOPASS_HOMEDIR IIRC).

Furthermore, the fact that in #2916 it's working for the root store but not substores seems to hint at a deeper problem in how we handle substore vs root store paths.

[AnomalRoil]

I think the deeper problem here is that ~ is a shell meta-character, and so paths starting with ~ have been set by incorrectly quoting "~" while setting the path, thus preventing it from being expanded to $HOME by the shell itself, demo:

$ gopass config mounts.path
/home/anomalroil/.local/share/gopass/stores/root
$ gopass config mounts.path "~/.local/share/gopass/stores/root"
~/.local/share/gopass/stores/root
$ gopass config mounts.path
~/.local/share/gopass/stores/root
$ gopass config mounts.path ~/.local/share/gopass/stores/root
/home/anomalroil/.local/share/gopass/stores/root
$ gopass config mounts.path
/home/anomalroil/.local/share/gopass/stores/root

Note that bash does allow to have quoted ~ in $PATH, but most shells do not.

But I think the initial idea was to be able to share a gopass config across a team, and so supporting ~ makes sense I think.
Just maybe not at the git level, but at a upper level?

[ghost]

Does that mean I should change CleanPath to replace ~ with $HOME if $GOPASS_HOMEDIR is not set?

[dominikschulz]

@cal-andrew Not sure if CleanPath covers all instances, but I think it would be a good start. Changing this on the gitfs doesn't make sense as @AnomalRoil pointed out.

[ghost]

The PR now tries to replace ~ in CleanPath, and enables testing this in Windows.

[ghost]

Thank you!