-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the schema to v1.05.02-2022-11-01 and regenerate code #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gstvg
commented
Jun 29, 2022
- stringer: use go install instead of go get
- skip enums with no values, e.g. the abstract Enumeration
- remove Bad/Uncertain, already included on status.csv and remove quote
- import new package location
- remove unexistent stats cmd call and stringer, switch stringer to go install
- sh raises error with set -o pipefail, switch to bash
- run update-schema.sh
- run make gen
- go mod tidy for new crypto example lib import location
magiconair
force-pushed
the
schema-update
branch
from
March 23, 2023 09:51
98a88d0
to
28b5d12
Compare
I've rebased it to current |
@gstvg I think your changes are good as is. Nice cleanup and it's time for us to update the schema. I'll use this as an excuse to bump to 0.4 |
magiconair
force-pushed
the
schema-update
branch
from
June 13, 2023 15:33
d82564a
to
642c699
Compare
magiconair
changed the title
Update the schema and regenerate code
Update the schema to v1.05.02-2022-11-01 and regenerate code
Jun 13, 2023
magiconair
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.