setSession to nil in recreateSession action to avoid unnecessary CloseSession #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssion. In the client.go monitor loop, the recreateSession action builds a new session on the assumption that the server is no longer holding the previous. It does not clear the value of atomicSession, which leads to CloseSession being called in ActivateSession even if there are no old sessions to be removed. This behvior was referenced in issue gopcua#673.
magiconair
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
I think this is a good catch and I agree. I hope this fixes the issue in #673
|
I'm going to cut a new release once this is merged. @law-dwg could you maybe test if this fixes your problem as well? |
|
Released v0.5.3 |
|
Works from my side, thanks! |
|
Awesome!!! Thank you very much both @mvandergrift and @law-dwg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the client.go monitor loop, the recreateSession action builds a new session on the assumption that the server is no longer holding the previous. It does not clear the value of the Client's atomicSession, which leads to CloseSession being called in ActivateSession even if there are no old sessions on the server to be removed.
This behavior is referenced in issue #673.