New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resource provider allocations API for placement #2162

Merged

jtopjian merged 1 commit into gophercloud:master from abnvanand:placement-allocations

May 17, 2021

Contributor

abnvanand commented May 13, 2021

For #526

Links to the line numbers/files in the OpenStack source code that support the
code in this PR:

API doc:
https://docs.openstack.org/api-ref/placement/?expanded=list-resource-provider-usages-detail#list-resource-provider-allocations

API code:
https://github.com/openstack/placement/blob/2150dbf6880c379b52035b604c51048743c446a5/placement/handlers/allocation.py#L271

Contributor Author

abnvanand commented May 13, 2021

Hi @jtopjian. This PR adds API to get allocations for a resource provider.
Can you please review?

Thanks

theopenlab-ci bot commented May 13, 2021

Build succeeded.

gophercloud-unittest : SUCCESS in 3m 46s
gophercloud-acceptance-test : SUCCESS in 2h 26m 30s
gophercloud-acceptance-test-ironic : SUCCESS in 22m 59s

Contributor

jtopjian commented May 16, 2021

I think this is the best representation of the schema: https://github.com/openstack/placement/blob/6f00ba5f685183539d0ebf62a4741f2f6930e051/placement/schemas/allocation.py#L75-L126

It also details a project_id and user_id, however, from looking at the acceptance test output, those are not used in the final response.

Contributor

jtopjian commented May 16, 2021

@abnvanand Looks like this needs gofmt run on it. Other than that, this looks good to me and I can merge once that's fixed.


          Add resource provider allocations API for placement

306d9e0

Contributor Author

abnvanand commented May 17, 2021

Fixed formatting.

theopenlab-ci bot commented May 17, 2021

Build succeeded.

gophercloud-unittest : SUCCESS in 3m 47s
gophercloud-acceptance-test : SUCCESS in 1h 11m 22s
gophercloud-acceptance-test-ironic : SUCCESS in 23m 04s

jtopjian approved these changes

View reviewed changes

Contributor

jtopjian left a comment

LGTM - Thank you!

Contributor

jtopjian commented May 17, 2021

@abnvanand Thanks so much for working on this.

jtopjian merged commit cb7437a into gophercloud:master

coveralls commented May 17, 2021

Coverage increased (+0.01%) to 79.877% when pulling 306d9e0 on abnvanand:placement-allocations into 2841b2e on gophercloud:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet