Add support for deleting nova service #2427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution, I guess this one can't be tested in acceptance, because once a service is removed, this can't be re-added from API, AFIK. |
EmilienM
reviewed
Jul 14, 2022
| // Delete will delete the existing service with the provided ID. | ||
| func Delete(client *gophercloud.ServiceClient, id string) (r DeleteResult) { | ||
| resp, err := client.Delete(updateURL(client, id), &gophercloud.RequestOpts{ | ||
| OkCodes: []int{204}, |
There was a problem hiding this comment.
mdelord
pushed a commit
to ovh/gophercloud
that referenced
this pull request
Oct 7, 2022
* Add support for deleting nova service * Add support for deleting nova service * fix Delete Result value * fix service delete response ok code * modify test * modify test * modify test * modify test Co-authored-by: 吴典秋 <muti_kube@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for deleting nova service
Fixes #2421
Reference:
https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/compute-service.html