-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix project page game content #1034
Conversation
This PR has been deployed to the preview environment. You can explore it using the preview URL. Warning Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team. |
@@ -116,6 +117,7 @@ export type ListProjectParams = PaginationParams & { | |||
} | |||
|
|||
export async function listProject(params?: ListProjectParams) { | |||
// TODO: released thumbnail for project list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里如果针对结果中的每个 project 都去 getLatestRelease
,可能有性能问题,晚点再细想一下;可能可以给 db project 表加个字段比如 releasedThumbnail
(在每次 publish 的时候去更新)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
有个可能会常见一些的做法是,db 加个 project.latest_release_id
,对应到 api 是 Project.latestRelease
(值是个 ProjectRelease
model)
另外这样上面通过 listReleases
来获取最新 release 的方法也就不需要了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗯这样更自然一些
@@ -116,6 +117,7 @@ export type ListProjectParams = PaginationParams & { | |||
} | |||
|
|||
export async function listProject(params?: ListProjectParams) { | |||
// TODO: released thumbnail for project list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
有个可能会常见一些的做法是,db 加个 project.latest_release_id
,对应到 api 是 Project.latestRelease
(值是个 ProjectRelease
model)
另外这样上面通过 listReleases
来获取最新 release 的方法也就不需要了
update #1033. Fix: