refactor: utilize Vercel Build Output API to reimplement API proxy #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces Vercel Edge Middleware with the Vercel Build Output API[^1] to reimplement the API proxy, cutting costs (no more invocation-based charges), reducing latency (no middle layer or cold starts), and simplifying the setup, while retaining dynamic configuration via the `VERCEL_PROXIED_API_BASE_URL` environment variable. Updates goplus#804 [^1]: https://vercel.com/docs/build-output-api/v3 Signed-off-by: Aofei Sheng <aofei@aofeisheng.com>
|
The PR environment is ready, please check the PR environment [Attention]: This environment will be automatically cleaned up after a certain period of time., please make sure to test it in time. If you have any questions, please contact the builder team. |
nighca
approved these changes
Aug 29, 2024
| rewrites: [ | ||
| { | ||
| source: '/api/(.*)', | ||
| destination: (env.VERCEL_PROXIED_API_BASE_URL as string) + '/$1' |
There was a problem hiding this comment.
看到这里我还很困惑，回忆了很久为啥我们当初用 middleware 而不是 vercel.json 中的 rewrites 来实现代理...
后来总算想起来是因为 vercel.json 中不好用环境变量？
There was a problem hiding this comment.
是因为
vercel.json中不好用环境变量？
是的，就只是因为这一点才用了 middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces Vercel Edge Middleware with the Vercel Build Output API1 to reimplement the API proxy, cutting costs (no more invocation-based charges), reducing latency (no middle layer or cold starts), and simplifying the setup, while retaining dynamic configuration via the
VERCEL_PROXIED_API_BASE_URLenvironment variable.Updates #804
Footnotes
https://vercel.com/docs/build-output-api/v3 ↩