Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: fix string extra check #1782

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

visualfc
Copy link
Member

fix parser panic

run "
panic: runtime error: slice bounds out of range [1:0] [recovered]
	panic: runtime error: slice bounds out of range [1:0]
goroutine 1 [running]:
github.com/goplus/gop/parser.parseFile.func1()
	/Users/vfc/goplus/gop/parser/interface.go:96 +0x1f2
panic({0x1680080?, 0xc0000c81c8?})

fixed to

bug.gop:1:5: string literal not terminated

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.23%. Comparing base (ffe6653) to head (45c69bf).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1782      +/-   ##
==========================================
+ Coverage   92.22%   92.23%   +0.01%     
==========================================
  Files          40       40              
  Lines       11021    11023       +2     
==========================================
+ Hits        10164    10167       +3     
  Misses        694      694              
+ Partials      163      162       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xushiwei xushiwei merged commit 38aec77 into goplus:main Feb 26, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants