Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#builder #603 add default animation & animation binding #289

Merged
merged 5 commits into from
Jun 25, 2024

Conversation

JiepengTan
Copy link
Collaborator

@JiepengTan JiepengTan requested a review from xushiwei June 19, 2024 11:36
@JiepengTan JiepengTan changed the title add Awake event, add default animation binding #builder #603 #builder #603 add Awake event, add default animation binding Jun 20, 2024
@nighca
Copy link
Collaborator

nighca commented Jun 20, 2024

It seems that this is not included in this PR:

Support binding one animation to multiple statuses

@xushiwei
Copy link
Member

Although it helps code reuse, it increases the cost of understanding, so I tend not to support this feature.

@xushiwei xushiwei added go Pull requests that update Go code proposal Proposal and removed go Pull requests that update Go code labels Jun 21, 2024
@nighca
Copy link
Collaborator

nighca commented Jun 21, 2024

Although it helps code reuse, it increases the cost of understanding, so I tend not to support this feature.

@xushiwei Do you mean "Support binding one animation to multiple statuses"? If you prefer to limit that one animation can be bound to at most one status, what if the user want to use the same animation for two differnt statuses? We recommend him to create two animations with the same data?

@JiepengTan
Copy link
Collaborator Author

Although it helps code reuse, it increases the cost of understanding, so I tend not to support this feature.

The current implementation no longer requires the addition of the Awake method, so it no longer increases the cost of understanding

@JiepengTan JiepengTan changed the title #builder #603 add Awake event, add default animation binding #builder #603 add default animation & animation binding Jun 21, 2024
const (
StateDie string = "die"
StateTurn string = "turn"
StateGlide string = "glide"
Copy link
Collaborator

@nighca nighca Jun 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be state step

@xushiwei xushiwei merged commit ea894f5 into goplus:main Jun 25, 2024
3 checks passed
@JiepengTan JiepengTan deleted the builder#603_Animation_binding branch September 23, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants