fix: Unify Die behavior of initial / cloned sprite #314 #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nighca
reviewed
Sep 10, 2024
|
|
||
| func (p *Sprite) Destroy() { // delete this clone |
There was a problem hiding this comment.
As proposed here, a public method named DeleteThisClone is expected to be offered:
- Rename current
destroytodeleteThisClonefor compatibility with Scratch'sDelete This Clone
nighca
reviewed
Sep 11, 2024
sprite.go
Outdated
| } | ||
|
|
||
| func (p *Sprite) Destroy() { | ||
| func (p *Sprite) doDestroy() { |
There was a problem hiding this comment.
A public method called Destroy as part of the sprite's APIs is also expected.
- Introduce new
destroy, which always destroys the current instance, regardless of whether it's the initial or a cloned instance
| @@ -509,6 +509,14 @@ func (p *Sprite) Destroy() { | |||
| } | |||
| } | |||
|
|
|||
| func (p *Sprite) DeleteThisClone() { | |||
There was a problem hiding this comment.
It is advisable to comment for the purpose of DeleteThisClone here, as it appears redundant with Destroy and Die provided.
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify Die behavior of initial / cloned sprite #314
This fix is temporary. It's better to switch to the prefab/instance workflow like unity.