Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Try Go+" in goplus.org homepage #46

Merged
merged 9 commits into from
Jan 13, 2022
Merged

"Try Go+" in goplus.org homepage #46

merged 9 commits into from
Jan 13, 2022

Conversation

nighca
Copy link
Collaborator

@nighca nighca commented Jan 11, 2022 •
edited
Loading

fix #45

@vercel
Copy link

vercel bot commented Jan 11, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goplus/www/BTvysyanJdNHe1asvRtQtER4Mdyw
✅ Preview: https://www-git-fork-nighca-try-gop-goplus.vercel.app

@nighca nighca changed the title "Try Go+" in goplus.org homepage [WIP] "Try Go+" in goplus.org homepage Jan 11, 2022
@nighca nighca changed the title [WIP] "Try Go+" in goplus.org homepage "Try Go+" in goplus.org homepage Jan 11, 2022
@nighca nighca changed the title "Try Go+" in goplus.org homepage [WIP] "Try Go+" in goplus.org homepage Jan 12, 2022
@nighca
Copy link
Collaborator Author

nighca commented Jan 12, 2022

@xushiwei Would you like to check this change? The preview version is here: https://www-git-fork-nighca-try-gop-goplus.vercel.app/

@xushiwei
Copy link
Member

LGTM

@nighca nighca changed the title [WIP] "Try Go+" in goplus.org homepage "Try Go+" in goplus.org homepage Jan 12, 2022
2788
2788 approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@2788 2788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

goplus.org/components/Code/Editor/style.module.scss Outdated
.footer {
margin-top: 24px;
display: flex;
flex-direction: row-reverse;
Copy link
Contributor

@2788 2788 Jan 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIP: 这里是想靠右吗？如果是靠右的话，后期如果加入了其他按钮，顺序就是逆序的（jsx），感觉有点奇怪，justify-content: flex-end 稍微好点

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯我来调整下

@nighca nighca merged commit 5a0831d into goplus:master Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2788 2788 2788 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Try Go+" in goplus.org homepage
3 participants
@nighca @xushiwei @2788