Run black on inotify #1015
Merged
Run black on inotify #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run `black` on `src/watchdog/observers/inotify.py`. Fixes failing `flake8` tests: Before: ------- ``` (.venv) abramowi at Marcs-MacBook-Pro-3 in ~/Code/OpenSource/watchdog (master●) $ python -m tox -e flake8 flake8: install_deps> python -I -m pip install -r requirements-tests.txt .pkg: _optional_hooks> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__ .pkg: get_requires_for_build_editable> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__ .pkg: build_editable> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__ flake8: install_package_deps> python -I -m pip install 'PyYAML>=3.10' flake8: install_package> python -I -m pip install --force-reinstall --no-deps /Users/abramowi/Code/OpenSource/watchdog/.tox/.tmp/package/12/watchdog-3.0.1-0.editable-cp310-cp310-macosx_12_0_arm64.whl flake8: commands[0]> python -m flake8 docs tools src tests setup.py src/watchdog/observers/inotify.py:224:86: W504 line break after binary operator src/watchdog/observers/inotify.py:225:88: W504 line break after binary operator flake8: exit 1 (0.40 seconds) /Users/abramowi/Code/OpenSource/watchdog> python -m flake8 docs tools src tests setup.py pid=76654 .pkg: _exit> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__ flake8: FAIL code 1 (9.23=setup[8.83]+cmd[0.40] seconds) evaluation failed :( (10.10 seconds) ``` After: ------ ``` (.venv) abramowi at Marcs-MacBook-Pro-3 in ~/Code/OpenSource/watchdog (master●) $ python -m tox -e flake8 .pkg: _optional_hooks> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__ .pkg: get_requires_for_build_editable> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__ .pkg: build_editable> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__ flake8: install_package> python -I -m pip install --force-reinstall --no-deps /Users/abramowi/Code/OpenSource/watchdog/.tox/.tmp/package/13/watchdog-3.0.1-0.editable-cp310-cp310-macosx_12_0_arm64.whl flake8: commands[0]> python -m flake8 docs tools src tests setup.py .pkg: _exit> python /Users/abramowi/Code/OpenSource/watchdog/.venv/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__ flake8: OK (1.59=setup[1.11]+cmd[0.48] seconds) congratulations :) (2.45 seconds) ```
|
I added black + isort configurations. Would you mind running black again 🙏🏻 ? |
Of course! See 753c717. |
|
and ran isort in 9963a77. |
|
Thank you @msabramo ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run
blackonsrc/watchdog/observers/inotify.py. Fixes failingflake8tests (like this one):Before:
After: