Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kqueue.control() only accepts positional parameters #1062

Merged
merged 2 commits into from
Sep 2, 2024
Merged

kqueue.control() only accepts positional parameters #1062

merged 2 commits into from
Sep 2, 2024

Conversation

apoirier
Copy link
Contributor

@apoirier apoirier commented Sep 2, 2024

A TypeError, kqueue.control() takes no keyword argumentsTypeError is raised

nagareproject added a commit to nagareproject/services-reloader that referenced this pull request Sep 2, 2024
@nagareproject
Staying on watchdog<5.0.0 while gorakhargosh/watchdog#1062 is not f…
c7a59d5 
…ixed
@BoboTiG
Copy link
Collaborator

BoboTiG commented Sep 2, 2024

Thank you @apoirier, I'll cut a new release containing your fix! 🍾

@BoboTiG
Copy link
Collaborator

BoboTiG commented Sep 2, 2024 •
edited
Loading

With this patch, your project works as expected? I would like to fix any other kqueue issues at once.

@BoboTiG
docs: changelog
6911e57 
[skip ci]
@BoboTiG BoboTiG merged commit 72be3e4 into gorakhargosh:master Sep 2, 2024
@apoirier
Copy link
Contributor Author

apoirier commented Sep 2, 2024

Yes, with this patch the reloader service of our nagare framework works fine as before
https://github.com/nagareproject/services-reloader/blob/master/src/nagare/services/reloader.py#L27

@BoboTiG
Copy link
Collaborator

BoboTiG commented Sep 2, 2024

And voilà, v5.0.1 is online 🥂

nagareproject added a commit to nagareproject/services-reloader that referenced this pull request Sep 3, 2024
@nagareproject
gorakhargosh/watchdog#1062 fixed
701b23e
BoboTiG added a commit to BoboTiG/watchdog that referenced this pull request Sep 3, 2024
@BoboTiG
Enable OS specific Mypy checks
a42fe5f 
It would have helped to catch gorakhargosh#1062 before the release.
github-actions bot pushed a commit to wxx9248/Pickle-Rush that referenced this pull request Sep 3, 2024
@dependabot
Dependency Updates: Bump watchdog from 5.0.0 to 5.0.1 (#111)
cf830a3 
Bumps [watchdog](https://github.com/gorakhargosh/watchdog) from 5.0.0 to
5.0.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/gorakhargosh/watchdog/releases">watchdog's
releases</a>.</em></p>
<blockquote>
<h2>5.0.1</h2>
<ul>
<li>[kqueue] Fix <code>TypeError: kqueue.control() only accepts
positional parameters</code> (<a
href="https://github.com/gorakhargosh/watchdog/issues/1062">#1062</a>)</li>
</ul>
<p>💟 Thanks to our beloved contributors: <a
href="https://github.com/apoirier"><code>@​apoirier</code></a>, <a
href="https://github.com/BoboTiG"><code>@​BoboTiG</code></a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/gorakhargosh/watchdog/blob/master/changelog.rst">watchdog's
changelog</a>.</em></p>
<blockquote>
<p>5.0.1</p>
<pre><code>
2024-09-02 • `full history
&lt;https://github.com/gorakhargosh/watchdog/compare/v5.0.0...v5.0.1&gt;`__
<ul>
<li>[kqueue] Fix <code>TypeError: kqueue.control() only accepts
positional parameters</code>
(<code>[#1062](gorakhargosh/watchdog#1062)
&amp;lt;https://github.com/gorakhargosh/watchdog/pull/1062&amp;gt;</code>__)</li>
<li>Thanks to our beloved contributors: <a
href="https://github.com/apoirier"><code>@​apoirier</code></a>, <a
href="https://github.com/BoboTiG"><code>@​BoboTiG</code></a>
</code></pre></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/gorakhargosh/watchdog/commit/8658cfc3f152104d108959c066c95cb9be3fc076"><code>8658cfc</code></a>
Version 5.0.1</li>
<li><a
href="https://github.com/gorakhargosh/watchdog/commit/cede9b6e6db5319687de45db280d684945464f25"><code>cede9b6</code></a>
chore: run ruff</li>
<li><a
href="https://github.com/gorakhargosh/watchdog/commit/72be3e43fdd6f8057a3a6f97d9fa1b00167eac6b"><code>72be3e4</code></a>
[kqueue] fix <code>TypeError: kqueue.control() only accepts positional
parameters</code>...</li>
<li><a
href="https://github.com/gorakhargosh/watchdog/commit/5daadf57e8c58212212a6e8d2b8854a722c60408"><code>5daadf5</code></a>
docs: tweak</li>
<li><a
href="https://github.com/gorakhargosh/watchdog/commit/ca453f52a92c4b2c2e94a557239e76254b3d3bdc"><code>ca453f5</code></a>
Bump the version</li>
<li><a
href="https://github.com/gorakhargosh/watchdog/commit/7c6ca3b626ae6689c876eff4fc129c7d30452982"><code>7c6ca3b</code></a>
docs: tweak</li>
<li>See full diff in <a
href="https://github.com/gorakhargosh/watchdog/compare/v5.0.0...v5.0.1">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=watchdog&package-manager=pip&previous-version=5.0.0&new-version=5.0.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@BoboTiG BoboTiG mentioned this pull request Sep 3, 2024
Merged
BoboTiG added a commit that referenced this pull request Sep 3, 2024
@BoboTiG
Enable OS specific Mypy checks (#1064)
2f5377a 
* Enable OS specific Mypy checks

It would have helped to catch #1062 before the release.

* ci: split & improve
miniscruff pushed a commit to miniscruff/scopie that referenced this pull request Sep 7, 2024
@dependabot
Bump the pip-deps group with 2 updates (#46)
c64b0d8 
Bumps the pip-deps group with 2 updates:
[mkdocs-material](https://github.com/squidfunk/mkdocs-material) and
[watchdog](https://github.com/gorakhargosh/watchdog).

Updates `mkdocs-material` from 9.5.33 to 9.5.34
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/squidfunk/mkdocs-material/releases">mkdocs-material's
releases</a>.</em></p>
<blockquote>
<h2>mkdocs-material-9.5.34</h2>
<ul>
<li>Updated Mermaid.js to version 11 (latest)</li>
</ul>
<p>Thanks go to <a
href="https://github.com/manselmi"><code>@​manselmi</code></a> for their
contributions</p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/squidfunk/mkdocs-material/blob/master/CHANGELOG">mkdocs-material's
changelog</a>.</em></p>
<blockquote>
<p>mkdocs-material-9.5.34 (2024-08-31)</p>
<ul>
<li>Updated Mermaid.js to version 11 (latest)</li>
</ul>
<p>mkdocs-material-9.5.33 (2024-08-23)</p>
<ul>
<li>Fixed <a
href="https://github.com/squidfunk/mkdocs-material/issues/7453">#7453</a>:
Incorrect position of tooltip when sorting table</li>
</ul>
<p>mkdocs-material-9.5.32 (2024-08-19)</p>
<ul>
<li>Fixed RXSS vulnerability via deep link in search results</li>
<li>Added support for fetching latest release from GitLab</li>
</ul>
<p>mkdocs-material-9.5.31+insiders-4.53.12 (2024-08-02)</p>
<ul>
<li>Fixed <a
href="https://github.com/squidfunk/mkdocs-material/issues/7410">#7410</a>:
Instant previews jump on content tabs with anchor links</li>
<li>Fixed <a
href="https://github.com/squidfunk/mkdocs-material/issues/7408">#7408</a>:
Instant previews jump on content tabs</li>
</ul>
<p>mkdocs-material-9.5.31 (2024-08-02)</p>
<ul>
<li>Fixed <a
href="https://github.com/squidfunk/mkdocs-material/issues/7405">#7405</a>:
DockerHub missing images &gt; 9.5.27 due to change in Alpine/APK</li>
</ul>
<p>mkdocs-material-9.5.30 (2024-07-23)</p>
<ul>
<li>Fixed <a
href="https://github.com/squidfunk/mkdocs-material/issues/7380">#7380</a>:
Navigation icons disappearing on hover in Safari</li>
<li>Fixed <a
href="https://github.com/squidfunk/mkdocs-material/issues/7367">#7367</a>:
Blog readtime computation includes SVG text content</li>
</ul>
<p>mkdocs-material-9.5.29 (2024-07-14)</p>
<ul>
<li>Updated Galician translations</li>
<li>Fixed <a
href="https://github.com/squidfunk/mkdocs-material/issues/7362">#7362</a>:
Annotations in figure captions rendering incorrectly</li>
</ul>
<p>mkdocs-material-9.5.28 (2024-07-02)</p>
<ul>
<li>Fixed <a
href="https://github.com/squidfunk/mkdocs-material/issues/7313">#7313</a>:
Improved tooltips mounted in sidebar when feature is disabled</li>
</ul>
<p>mkdocs-material-9.5.27 (2024-06-16)</p>
<ul>
<li>Updated Estonian translations</li>
</ul>
<p>mkdocs-material-9.5.26 (2024-06-06)</p>
<ul>
<li>Fixed <a
href="https://github.com/squidfunk/mkdocs-material/issues/7232">#7232</a>:
Tab switches on scroll when linking tabs (9.5.19 regression)</li>
<li>Fixed <a
href="https://github.com/squidfunk/mkdocs-material/issues/7230">#7230</a>:
Blog author avatar broken when referring to local file</li>
</ul>
<p>mkdocs-material-9.5.25+insiders-4.53.11 (2024-05-27)</p>
<ul>
<li>Fixed projects plugin crashing when serving before building
subprojects</li>
</ul>
<p>mkdocs-material-9.5.25 (2024-05-27)</p>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/squidfunk/mkdocs-material/commit/7d6096ae007580d53f9c034476615c9fe7b95e6c"><code>7d6096a</code></a>
Prepare 9.5.34 release</li>
<li><a
href="https://github.com/squidfunk/mkdocs-material/commit/6f3c05b6fa7e42279ea7604aedc4e4333131fe57"><code>6f3c05b</code></a>
Updated dependencies</li>
<li><a
href="https://github.com/squidfunk/mkdocs-material/commit/d3b17920a2683118561c00ab2e8f72b995985edb"><code>d3b1792</code></a>
Updated Mermaid to v11 (<a
href="https://github.com/squidfunk/mkdocs-material/issues/7475">#7475</a>)</li>
<li><a
href="https://github.com/squidfunk/mkdocs-material/commit/f88c43695f233b8258d585d63a9dc34511fc4433"><code>f88c436</code></a>
Unpinned Stylelint and plugins</li>
<li><a
href="https://github.com/squidfunk/mkdocs-material/commit/3b12816f699ea9390b1b622fc96aec1013da7a6d"><code>3b12816</code></a>
Unpinned TypeScript ESLint integration and checks</li>
<li><a
href="https://github.com/squidfunk/mkdocs-material/commit/cafd67b7385077233ab2b9f7b245080c96a986d2"><code>cafd67b</code></a>
Fixed error in build script</li>
<li><a
href="https://github.com/squidfunk/mkdocs-material/commit/80ae56023ba6351f3c45124a8a407f17ff9ecf43"><code>80ae560</code></a>
Unpinned svgo dependency</li>
<li>See full diff in <a
href="https://github.com/squidfunk/mkdocs-material/compare/9.5.33...9.5.34">compare
view</a></li>
</ul>
</details>
<br />

Updates `watchdog` from 5.0.0 to 5.0.2
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/gorakhargosh/watchdog/releases">watchdog's
releases</a>.</em></p>
<blockquote>
<h2>5.0.2</h2>
<ul>
<li>Enable OS specific Mypy checks (<a
href="https://github.com/gorakhargosh/watchdog/issues/1064">#1064</a>)</li>
<li>[watchmedo] Fix <code>tricks</code> argument type of
<code>schedule_tricks()</code> (<a
href="https://github.com/gorakhargosh/watchdog/issues/1063">#1063</a>)</li>
</ul>
<p>💟 Thanks to our beloved contributors: <a
href="https://github.com/gnought"><code>@​gnought</code></a>, <a
href="https://github.com/BoboTiG"><code>@​BoboTiG</code></a></p>
<h2>5.0.1</h2>
<ul>
<li>[kqueue] Fix <code>TypeError: kqueue.control() only accepts
positional parameters</code> (<a
href="https://github.com/gorakhargosh/watchdog/issues/1062">#1062</a>)</li>
</ul>
<p>💟 Thanks to our beloved contributors: <a
href="https://github.com/apoirier"><code>@​apoirier</code></a>, <a
href="https://github.com/BoboTiG"><code>@​BoboTiG</code></a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/gorakhargosh/watchdog/blob/master/changelog.rst">watchdog's
changelog</a>.</em></p>
<blockquote>
<p>5.0.2</p>
<pre><code>
2024-09-03 • `full history
&lt;https://github.com/gorakhargosh/watchdog/compare/v5.0.1...v5.0.2&gt;`__
<ul>
<li>Enable OS specific Mypy checks
(<code>[#1064](gorakhargosh/watchdog#1064)
&amp;lt;https://github.com/gorakhargosh/watchdog/pull/1064&amp;gt;</code>__)</li>
<li>[watchmedo] Fix <code>tricks</code> argument type of
<code>schedule_tricks()</code>
(<code>[#1063](gorakhargosh/watchdog#1063)
&amp;lt;https://github.com/gorakhargosh/watchdog/pull/1063&amp;gt;</code>__)</li>
<li>Thanks to our beloved contributors: <a
href="https://github.com/gnought"><code>@​gnought</code></a>, <a
href="https://github.com/BoboTiG"><code>@​BoboTiG</code></a></li>
</ul>
<p>5.0.1
</code></pre></p>
<p>2024-09-02 • <code>full history
&lt;https://github.com/gorakhargosh/watchdog/compare/v5.0.0...v5.0.1&gt;</code>__</p>
<ul>
<li>[kqueue] Fix <code>TypeError: kqueue.control() only accepts
positional parameters</code>
(<code>[#1062](gorakhargosh/watchdog#1062)
&lt;https://github.com/gorakhargosh/watchdog/pull/1062&gt;</code>__)</li>
<li>Thanks to our beloved contributors: <a
href="https://github.com/apoirier"><code>@​apoirier</code></a>, <a
href="https://github.com/BoboTiG"><code>@​BoboTiG</code></a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/gorakhargosh/watchdog/commit/2b628306d5983f96cfec1ab46f4205b2f6208d92"><code>2b62830</code></a>
Version 5.0.2</li>
<li><a
href="https://github.com/gorakhargosh/watchdog/commit/2f5377acb378be034c24e3b21742f0c3e3283649"><code>2f5377a</code></a>
Enable OS specific Mypy checks (<a
href="https://github.com/gorakhargosh/watchdog/issues/1064">#1064</a>)</li>
<li><a
href="https://github.com/gorakhargosh/watchdog/commit/4427aa442f1964ac44e27924e2e18f152b5326b2"><code>4427aa4</code></a>
[watchmedo] Fix <code>tricks</code> argument type of
<code>schedule_tricks()</code> (<a
href="https://github.com/gorakhargosh/watchdog/issues/1063">#1063</a>)</li>
<li><a
href="https://github.com/gorakhargosh/watchdog/commit/236a57ccce81ec1b2110fca0e8c81a86e34e4412"><code>236a57c</code></a>
Bump the version</li>
<li><a
href="https://github.com/gorakhargosh/watchdog/commit/8658cfc3f152104d108959c066c95cb9be3fc076"><code>8658cfc</code></a>
Version 5.0.1</li>
<li><a
href="https://github.com/gorakhargosh/watchdog/commit/cede9b6e6db5319687de45db280d684945464f25"><code>cede9b6</code></a>
chore: run ruff</li>
<li><a
href="https://github.com/gorakhargosh/watchdog/commit/72be3e43fdd6f8057a3a6f97d9fa1b00167eac6b"><code>72be3e4</code></a>
[kqueue] fix <code>TypeError: kqueue.control() only accepts positional
parameters</code>...</li>
<li><a
href="https://github.com/gorakhargosh/watchdog/commit/5daadf57e8c58212212a6e8d2b8854a722c60408"><code>5daadf5</code></a>
docs: tweak</li>
<li><a
href="https://github.com/gorakhargosh/watchdog/commit/ca453f52a92c4b2c2e94a557239e76254b3d3bdc"><code>ca453f5</code></a>
Bump the version</li>
<li><a
href="https://github.com/gorakhargosh/watchdog/commit/7c6ca3b626ae6689c876eff4fc129c7d30452982"><code>7c6ca3b</code></a>
docs: tweak</li>
<li>See full diff in <a
href="https://github.com/gorakhargosh/watchdog/compare/v5.0.0...v5.0.2">compare
view</a></li>
</ul>
</details>
<br />


Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apoirier @BoboTiG