250 - Fix inotify stop dead lock. #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamland
added a commit
that referenced
this pull request
Jul 17, 2014
Fix inotify stop dead lock. Closes #250
CCP-Aporia
pushed a commit
to CCP-Aporia/watchdog
that referenced
this pull request
Aug 13, 2020
Fix inotify stop dead lock. Closes gorakhargosh#250
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See description from #250
inotify.stop() thread never ends since it continue to wait for inotify_buffer, but the buffer is closed and will never emit a new event.
Changes
I have fixed this my emitting a one last special event to signal that inotify_buffer was closed.
py.test magic with tmpdir and p is strange ... this reminds me of AngularJS ... and pyflakes is not happy with it. :(
I have updated the README as it was not obvious that py.test is used.
How to test
You can try this code https://gist.github.com/adiroiban/064b3a5e07d404ea7109
or use the provided automated test