Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable possibility to enforce PollingObserver by setting the environment variable WATCHMEDO_FORCE_POLLING #289

Closed
wants to merge 7 commits into from

Conversation

peterlauri
Copy link

This enables possibility to enforce the usage of PollingObserver by setting the environment variable WATCHMEDO_FORCE_POLLING.

@peterlauri
Copy link
Author

I see that the Travis CI build fails, but it looks to be a timeout issue.

@tamland
Copy link
Collaborator

tamland commented Dec 21, 2014

I suggest doing something similar to --debug-force-polling from log just to keep things consistent. (More like your initial version.) Feel free to load environment variables etc. in watchmedo parts, but loading environment variables in the core python API is IMO not a very good idea and it could lead to all sorts of weird issues. (Anyone using the python API should explicitly import polling if they want it)

@peterlauri
Copy link
Author

Actually, I was trying to keep it consistent in the end, by loading the proper Observer in init.py based on the environment, as well as the other switches are relying on the type of platform. And this wouldn't have any side effects on people using the python API, of course it needs to be documented.

…it is just related to watchmedo, and not to the python API
@peterlauri
Copy link
Author

But, I do think that there should be an command line option for watchmedo as well, not just to rely on the environment variable.

@mafrosis
Copy link
Contributor

+1 this will enable watchmedo to be used over network fileshare. Related to #316

@tamland
Copy link
Collaborator

tamland commented Oct 26, 2015

Closing in favor of #336

@tamland tamland closed this Oct 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants