Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identify synthesized events #369

Closed
wants to merge 2 commits into from
Closed

Conversation

skurfer
Copy link
Contributor

@skurfer skurfer commented Aug 12, 2016

…so packages using the library can distinguish between those, and actual moves.

@DonyorM
Copy link
Contributor

DonyorM commented Oct 28, 2016

Could you add a comment defining exactly what a "synthesized" event is. It's not clear from either the field definition or the description.

@skurfer
Copy link
Contributor Author

skurfer commented Feb 1, 2017

I’ve expanded the description. Let me know if it needs to be adjusted.

@BoboTiG
Copy link
Collaborator

BoboTiG commented Oct 13, 2018

Thank you @skurfer, do you think you can add tests and rebase on master?

@mbakiev
Copy link
Contributor

mbakiev commented Oct 15, 2018

Can we set the is_synthetic flag for events generated by generate_sub_created_events as well?

@BoboTiG
Copy link
Collaborator

BoboTiG commented Oct 21, 2018

@mbakiev, yes that would be logical too.

BoboTiG added a commit to BoboTiG/watchdog that referenced this pull request Feb 17, 2019
BoboTiG pushed a commit to BoboTiG/watchdog that referenced this pull request Feb 17, 2019
@BoboTiG BoboTiG closed this in #536 Feb 17, 2019
BoboTiG pushed a commit that referenced this pull request Feb 17, 2019
CCP-Aporia pushed a commit to CCP-Aporia/watchdog that referenced this pull request Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants