Fix crash on shutdown #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see no assert or any sort of actual test in your test method. Forgive me if I'm missing something, but what are you expecting to find there? |
|
Without the patch applied, |
|
Ahhh, I see. Yes, a quick comment would be helpful, in case someone is looking over this in the future. But leave the test, it's helpful in case someone makes an edit that causes the problem to come back. |
When the root directory being watched by inotify was deleted, watchdog would crash with a KeyError when shutting down. This commit stops watching the deleted directory for events once it's been deleted, as well as adds a guard for the crash.
|
@DonyorM: Added a comment |
|
Thanks for helping out with this! |
CCP-Aporia
pushed a commit
to CCP-Aporia/watchdog
that referenced
this pull request
Aug 13, 2020
Fix crash on shutdown when root directory deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the root directory being watched by inotify was deleted, watchdog
would crash with a KeyError when shutting down.
This commit stops watching the deleted directory for events once it's
been deleted, as well as adds a guard for the crash.