Fixed constant in winapi.py. #376
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed winapi.py accordingly to kernel32.dll documentation. After file not found errors in line 276:
def get_directory_handle(path):
"""Returns a Windows handle to the specified directory path."""
return CreateFileW(path, FILE_LIST_DIRECTORY, WATCHDOG_FILE_SHARE_FLAGS,
None, OPEN_EXISTING, WATCHDOG_FILE_FLAGS, None)
during watchdog startup on win2008 server.
|
But |
|
It seems the kernel32.dll on win 2008 server running in VMWare disagrees on that. Could be the endianess. Let python handle it for you and everything is right. |
|
LGTM. |
CCP-Aporia
pushed a commit
to CCP-Aporia/watchdog
that referenced
this pull request
Aug 13, 2020
Fixed constant in winapi.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed constant in winapi.py to
FILE_LIST_DIRECTORY = 1from
FILE_LIST_DIRECTORY = 0x01accordingly to kernel32.dll documentation after file not found errors in line 276
during watchdog startup on win2008 server.