Avoid race condition crash when a directory is swapped for a file #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit builds off the race condition checking introduced in 2e83199, but also correctly handles the case where a directory is replaced with a file before it can be walked. For example: 1. [external] create /a/b/c.txt 2. [watchdog] walk /a (contains directory /a/b/ at this point) 3. [external] rm -rf /a/b/ 4. [external] touch /a/b 5. [watchdog] walk /a/b/ (raises NotADirectoryError)
|
@gorakhargosh Anything else I need to do for this? |
|
Hello @pR0Ps, thank you foryour interest. Could you add test cases? |
|
Obsolete, see #513 for an updated PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit builds off the race condition checking introduced in
2e83199, but also correctly handles the case where a directory is
replaced with a file before it can be walked.
For example:
/a/b/c.txt/a(contains directory/a/b/at this point)rm -rf /a/b/touch /a/b/a/b/(raisesNotADirectoryError)