Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use scandir to save memory #503

Merged
merged 1 commit into from
Dec 25, 2018

Conversation

QuantumEnergyE
Copy link
Contributor

Use scandir to save memory.

@QuantumEnergyE QuantumEnergyE force-pushed the listdir_to_scandir branch 3 times, most recently from 43f05c2 to 12076b8 Compare December 22, 2018 17:06
@BoboTiG
Copy link
Collaborator

BoboTiG commented Dec 22, 2018

Thanks, LGTM.

Could you remove the import os from polling.py? It becomes useless.

@QuantumEnergyE
Copy link
Contributor Author

Thanks, LGTM.

Could you remove the import os from polling.py? It becomes useless.

I have removed import os from polling.py

@BoboTiG
Copy link
Collaborator

BoboTiG commented Dec 23, 2018

Last thing, perhaps this line should mention os.scandir. Something like:

Use custom listdir function. For details see os.scandir if available, else os.listdir.

@QuantumEnergyE
Copy link
Contributor Author

Last thing, perhaps this line should mention os.scandir. Something like:

Use custom listdir function. For details see os.scandir if available, else os.listdir.

Thanks,PTAL.

@BoboTiG BoboTiG merged commit 2cea5e8 into gorakhargosh:master Dec 25, 2018
@BoboTiG
Copy link
Collaborator

BoboTiG commented Dec 25, 2018

Thanks @QuantumEnergyE!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants