Fix inotify behavior when presented with non-ASCII path events

[exarkun]

Fixes #516

[BoboTiG]

Hello @exarkun , thanks for the patch!

Could you change that line to:

python -bb -m pytest {posargs}

It will ensure there is no BytesWarning.

[exarkun]

Hello @exarkun , thanks for the patch!

Could you change that line to:

python -bb -m pytest {posargs}

It will ensure there is no BytesWarning.

Sure thing. Done.

[BoboTiG]

Thanks for the changes, and I am sorry to ask you one last thing :)
I was trying to reproduce the error that was fixed with the commit you are partially reverting with this PR. This is simply to ensure no regression.

Could you apply those changes (I should have done it way sooner):

diff --git a/tests/conftest.py b/tests/conftest.py
index ed58af3..418a58d 100644
--- a/tests/conftest.py
+++ b/tests/conftest.py
@@ -20,3 +20,22 @@ def p(tmpdir, *args):
     with the provided arguments.
     """
     return partial(os.path.join, tmpdir)
+
+
+
+@pytest.fixture(autouse=True)
+def no_warnings(recwarn):
+    """Fail on warning."""
+
+    yield
+
+    warnings = []
+    for warning in recwarn:  # pragma: no cover
+        message = str(warning.message)
+        if (
+            "Not importing directory" in message
+            or "Using or importing the ABCs" in message
+        ):
+            continue
+        warnings.append("{w.filename}:{w.lineno} {w.message}".format(w=warning))
+    assert not warnings

With this fixture, you will see several failures related to your changes and this is what we tried to fix in the older commit.

Many many thanks for your patience, time and work 💪

[exarkun]

@BoboTiG The no-warnings fixture is now in place and I've fixed the test failures where such warnings were being triggered (probably; macOS travis jobs still running, the rest are green).

[BoboTiG]

Thanks @exarkun :)