Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Python 3.6 installation when the OS locale is set to POSIX #616

Merged
merged 3 commits into from
Jan 27, 2020
Merged

Fix Python 3.6 installation when the OS locale is set to POSIX #616

merged 3 commits into from
Jan 27, 2020

Conversation

tehkirill
Copy link
Contributor

@tehkirill tehkirill commented Jan 27, 2020 •
edited by BoboTiG

Fixes #615.

@tehkirill tehkirill mentioned this pull request Jan 27, 2020
Closed
@BoboTiG
Copy link
Collaborator

BoboTiG commented Jan 27, 2020 •
edited

To fix errors, maybe this line at the top of the file would be enough:

from codecs import open

Also, can you add your GH nickname + history change? I am thinking of something like:

- Fixed Python 3.6 installation when the OS locale is set to POSIX (`#615 <https://github.com/gorakhargosh/watchdog/pull/615>`__)

@tehkirill
Copy link
Contributor Author

To fix errors, maybe this line at the top of the file would be enough:

from codecs import open

Good shout, was going to go via .decode() route originally.

@BoboTiG BoboTiG changed the title enforce 'utf-8' encoding, fixes #615 Fix Python 3.6 installation when the OS locale is set to POSIX Jan 27, 2020
@BoboTiG BoboTiG added the bug label Jan 27, 2020
@BoboTiG BoboTiG merged commit d557574 into gorakhargosh:master Jan 27, 2020
@BoboTiG
Copy link
Collaborator

BoboTiG commented Jan 27, 2020

Thanks a lot @tehkirill :)

@tdhopper
Copy link

@BoboTiG are you able to cut a release to pypi?

@darakian darakian mentioned this pull request Jan 27, 2020
Closed
@darakian
Copy link

A new pypi release would be very helpful.

@BoboTiG
Copy link
Collaborator

BoboTiG commented Jan 31, 2020

@darakian Done :)

@darakian
Copy link

Thank you much @BoboTiG :)

CCP-Aporia pushed a commit to CCP-Aporia/watchdog that referenced this pull request Aug 13, 2020
@tehkirill @BoboTiG
Fix Python 3.6 installation when the OS locale is set to POSIX (gorak…
68fbeac 
…hargosh#616)

* enforce 'utf-8' encoding, fixes gorakhargosh#615

* using `open` from `codecs` for py2.7 support

* Updated changelog to reflect OS locale fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Watchdog v0.10.0 fails to install (UnicodeDecodeError): v0.9.0 works fine
4 participants
@tehkirill @BoboTiG @tdhopper @darakian