Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the build_ext command on macOS #622

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Fix the build_ext command on macOS #622

merged 1 commit into from
Jan 30, 2020

Conversation

BoboTiG
Copy link
Collaborator

@BoboTiG BoboTiG commented Jan 29, 2020

  • Fixed the build_ext command on macOS
  • Moved requirements to setup.cfg
  • [mac] Removed old C code for Python 2.5 in the fsevents C implementation

Fixes #617, #618 and #620.

@BoboTiG BoboTiG force-pushed the fix-use-sys-platform branch 10 times, most recently from cbb1aeb to ec4902e Compare January 30, 2020 07:27
- Removed old C code for Python 2.5
- Fixed error: equality comparison with extraneous parentheses
- Removed use of `distuils.util.get_platform()` for `sys.platform` in `setup.py`
- Removed `-Werror` to fix several issues when compiling the extension
- Moved requirements to `setup.cfg`
@BoboTiG BoboTiG changed the title Fix macOS build_ext for old and new versions Fixed the build_ext command on macOS Jan 30, 2020
@BoboTiG BoboTiG changed the title Fixed the build_ext command on macOS Fix the build_ext command on macOS Jan 30, 2020
@BoboTiG BoboTiG merged commit 6baa210 into master Jan 30, 2020
@BoboTiG BoboTiG deleted the fix-use-sys-platform branch January 30, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

second install of watchdog on non-macos incorrectly requires darwin dependencies
1 participant