Adapt tests to improve BSD support. #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a false Linux|Windows dichotomy in some tests, so instead of skipping certain tests on certain platforms, this now skips tests when *not* on the expected platform. E.g. InotifyFullEmitter tests shouldn't run on non-Linux and the Windows-specific tests shouldn't run on non-Windows.
|
Ouch, it looks like indeed the test I had doubts in is being problematic :-D. Yay, CI! |
evilham
changed the title
|
Thanks @evilham! Perhaps should you submit the test change in another PR? And just using this one to properly skip tests based on OS types. Also, could you add a line in the changelog + your GH name? |
That way CI is happy and changes are conceptually more isolated.
|
There is an unrelated failure regarding chocolatey: |
evilham
changed the title
|
Yes, this is a random bug on the CI. I relaunched the job and it passes 🍾 Thanks for the patch @evilham 💪 |
CCP-Aporia
pushed a commit
to CCP-Aporia/watchdog
that referenced
this pull request
Aug 13, 2020
* Adapt tests to improve BSD support. There was a false Linux|Windows dichotomy in some tests, so instead of skipping certain tests on certain platforms, this now skips tests when *not* on the expected platform. E.g. InotifyFullEmitter tests shouldn't run on non-Linux and the Windows-specific tests shouldn't run on non-Windows. * Revert change to `test_separate_consecutive_moves`. That way CI is happy and changes are conceptually more isolated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for #632.
The only doubt I have here is regarding:
test_separate_consecutive_moves:As far as the current KqueueEmitter is concerned, it looks like if we add a file from a different directory it is equivalent to that file being created and not renamed, as the test expects. Does this patch to the test make sense?
There was a false Linux|Windows dichotomy in some tests, so instead of
skipping certain tests on certain platforms, this now skips tests when
not on the expected platform.
E.g. InotifyFullEmitter tests shouldn't run on non-Linux and the
Windows-specific tests shouldn't run on non-Windows.