Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially restore support for BSD. #638

Merged
merged 3 commits into from
Feb 6, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.rst
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ Changelog
``PatternMatchingEventHandler`` and ``RegexMatchingEventHandler``
- Improve tests support on non Windows/Linux platforms (`#633 <https://github.com/gorakhargosh/watchdog/pull/633>`__)
- Added FreeBSD CI support (`#532 <https://github.com/gorakhargosh/watchdog/pull/532>`__)
- [BSD] Restore partial support (`#638 <https://github.com/gorakhargosh/watchdog/pull/638>`__)
- Thanks to our beloved contributors: @BoboTiG, @evilham


Expand Down
23 changes: 14 additions & 9 deletions src/watchdog/observers/kqueue.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@

import threading
import errno
import stat
from stat import S_ISDIR
import os
import select

Expand All @@ -85,6 +85,7 @@
DEFAULT_EMITTER_TIMEOUT
)

from watchdog.utils import stat as default_stat
from watchdog.utils.dirsnapshot import DirectorySnapshot

from watchdog.events import (
Expand All @@ -98,7 +99,8 @@
FileModifiedEvent,
EVENT_TYPE_MOVED,
EVENT_TYPE_DELETED,
EVENT_TYPE_CREATED
EVENT_TYPE_CREATED,
generate_sub_moved_events,
)

# Maximum number of events to process.
Expand Down Expand Up @@ -424,9 +426,11 @@ class KqueueEmitter(EventEmitter):
Read events blocking timeout (in seconds).
:type timeout:
``float``
:param stat: stat function. See ``os.stat`` for details.
"""

def __init__(self, event_queue, watch, timeout=DEFAULT_EMITTER_TIMEOUT):
def __init__(self, event_queue, watch, timeout=DEFAULT_EMITTER_TIMEOUT,
stat=default_stat):
EventEmitter.__init__(self, event_queue, watch, timeout)

self._kq = select.kqueue()
Expand All @@ -437,7 +441,7 @@ def __init__(self, event_queue, watch, timeout=DEFAULT_EMITTER_TIMEOUT):

def custom_stat(path, self=self):
stat_info = stat(path)
self._register_kevent(path, stat.S_ISDIR(stat_info.st_mode))
self._register_kevent(path, S_ISDIR(stat_info.st_mode))
return stat_info

self._snapshot = DirectorySnapshot(watch.path,
Expand Down Expand Up @@ -615,9 +619,10 @@ def _queue_renamed(self,
# the event represents deletion/creation instead of movement.
return

try:
dest_path = absolute_path(
new_snapshot.path(ref_stat_info.st_ino))
f_id = (ref_stat_info.st_ino, ref_stat_info.st_dev)
dest_path = new_snapshot.path(f_id)
if dest_path is not None:
dest_path = absolute_path(dest_path)
if is_directory:
event = DirMovedEvent(src_path, dest_path)
# TODO: Do we need to fire moved events for the items
Expand All @@ -626,12 +631,12 @@ def _queue_renamed(self,
# only if it doesn't already.
# A: It doesn't. So I've enabled this block.
if self.watch.is_recursive:
for sub_event in event.sub_moved_events():
for sub_event in generate_sub_moved_events(src_path, dest_path):
self.queue_event(sub_event)
self.queue_event(event)
else:
self.queue_event(FileMovedEvent(src_path, dest_path))
except KeyError:
else:
# If the new snapshot does not have an inode for the
# old path, we haven't found the new name. Therefore,
# we mark it as deleted and remove unregister the path.
Expand Down