Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to monitor single file #655

Merged
merged 5 commits into from
Apr 28, 2020
Merged

Conversation

brant-ruan
Copy link
Contributor

Currently on Linux using watchdog we can only monitor directories... But for many cases it is necessary to enable the users to monitor files (not directory)

@brant-ruan brant-ruan changed the title allow to monitor single file Allow to monitor single file Apr 2, 2020
@BoboTiG
Copy link
Collaborator

BoboTiG commented Apr 2, 2020

Hello @brant-ruan ,

Thanks for tackling that, would you mind adding a test?

@BoboTiG BoboTiG added the inotify label Apr 2, 2020
@brant-ruan
Copy link
Contributor Author

hello, I added one test funciton :)

@BoboTiG
Copy link
Collaborator

BoboTiG commented Apr 17, 2020

Ah super! Could you apply those changes to the changelog as well? 🙏 (in the 0.10.3 section, you are the first contributor 💪)

- [inotify] Allow to monitor single file (`#655 <https://github.com/gorakhargosh/watchdog/pull/655>`__)
- Thanks to our beloved contributors: @brant-ruan

@brant-ruan
Copy link
Contributor Author

Sure, thx :)

requirements-tests.txt Outdated Show resolved Hide resolved
@frispete
Copy link

Hi guys, I like this tone 😉

tests/test_inotify_c.py Outdated Show resolved Hide resolved
@BoboTiG BoboTiG merged commit 077d5b1 into gorakhargosh:master Apr 28, 2020
@BoboTiG
Copy link
Collaborator

BoboTiG commented Apr 28, 2020

Thanks a lot for you patience @brant-ruan :)

@brant-ruan
Copy link
Contributor Author

Thanks a lot for you patience @brant-ruan :)

🤝

CCP-Aporia pushed a commit to CCP-Aporia/watchdog that referenced this pull request Aug 13, 2020
Co-authored-by: ruanbonan <ruanbonan@intra.nsfocus.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants