Add support for non-recursive watches in FSEventsEmitter #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The underlying `fseventsd` service always observes recursively. As such we're adding a filter in `FSEventEmitter` to support the non-recursive behaviour that is supported by other emitters.
BoboTiG
reviewed
Apr 23, 2021
|
Of course. Was just waiting for the review before adding the relevant changelog entry. :-) Won't get around to all of it before Monday, though. |
Test a few more scenarios for non-recursive watches. Do note that at least on macOS we'll get a `DirModifiedEvent` for the created subdirectory.
|
Turns out that the additional test cases fail on Ubuntu and Windows. What would be the expected behaviour on these platforms for the added scenarios? The same as on macOS? |
We're fixing a defect on macOS after all, and addressing the failures on other platforms looks like opening a can of worms that is not related to the original issue.
|
You are right with the last commit, let's tackle macOS only for now :) |
|
@BoboTiG - shall we get this merged? 😄 The failed test on macOS / 3.7 seems to be a timing issue in a flaky test |
BoboTiG
approved these changes
May 3, 2021
|
Oh yes, sorry for the delay! Thanks for the patch :) |
|
Just making sure you're aware, this pull request caused issue #797. |
copybara-service bot
pushed a commit
to google/pigweed
that referenced
this pull request
Jun 10, 2021
See gorakhargosh/watchdog#779 No-Docs-Update-Reason: bug fix Change-Id: I6a5fd6bc7964e2da672593d50180cb9aa7b6b8c1 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/48521 Reviewed-by: Max Koopman <koopman@google.com> Reviewed-by: Wyatt Hepler <hepler@google.com> Commit-Queue: Michael Spang <spang@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying
fseventsdservice always observes recursively. As such we're adding a filter inFSEventEmitterto support the non-recursive behaviour that is supported by other emitters.Fixes #771