Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Fix" event detection right after starting an emitter on PyPy #796

Merged
merged 4 commits into from
May 12, 2021

Conversation

oprypin
Copy link
Contributor

@oprypin oprypin commented May 11, 2021

(Windows-specific)

And re-add PyPy to CI

#792

(Windows-specific)

And re-add PyPy to CI
@oprypin
Copy link
Contributor Author

oprypin commented May 11, 2021

Tests for the downstream project that I want to use "watchdog" in also look good with this:
https://github.com/oprypin/mkdocs/runs/2559473746?check_suite_focus=true

Failures without this, for reference:
https://github.com/mkdocs/mkdocs/runs/2549147666

Copy link
Collaborator

@BoboTiG BoboTiG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @oprypin!

Do you mind adding a line in the changelog + your nickname?

src/watchdog/observers/read_directory_changes.py Outdated Show resolved Hide resolved
oprypin and others added 3 commits May 12, 2021 16:42
@oprypin
Copy link
Contributor Author

oprypin commented May 12, 2021

Thanks for the merge, didn't realize it's needed. Seems like GitHub's UI prioritized the "CI can't be run" message over the "merge is needed" message.

@BoboTiG
Copy link
Collaborator

BoboTiG commented May 12, 2021

Thanks for the patch @oprypin, and good analysis 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants