-
-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
win32 fixes to avoid unix only apis in tricks/__init__.py #810
win32 fixes to avoid unix only apis in tricks/__init__.py #810
Conversation
I just saw that watchmedo tests are near to zero. Do you think you could add simple test(s) to cover your changes? |
Hi I'm not really certain how one should test this; I used the following code
but as a person who doesn't normally use Tox I don't know to test that the kill actually stops the task in the middle. There was no error and the test said it passed, but I would like to check that we didn't get to "+++++ 9" in the output. EDIT: apparently I need to start messing with pytest capsys plugin. I will take a few moments to figure out what to do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the test, really appreciated!
Not sure why these errors are so random. I tried in a forked rep and got different failures :( |
Random failures are OK as soon as the new test passes on Windows. |
I'm not windows savvy any more. I will have to try and run these on a windows 10 laptop and see if we never get the KeyboardInterrupt appearing in the subprocess output. |
OK tried various tricks to get the stderr from the subprocess and in windows it doesn't work. So the easiest is to just drop the requirement that the right exception is seen. |
That's good for me, thanks @replabrobin 🍾 |
Thanks BoboTiG; I'm never sure about the git philosophy here. Should I leave the branch in place in my repo or delete it or delete the whole repo? What's the 'right/nice' way? |
As you have another PR, it is a good practice to only delete the branch since it was merged. |
OK I have toxed this in linux, but I will need time to check the changes in windows 10