Fix SkipRepeatsQueue._put() raises AttributeError (#817) #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you mind adding a regression test? |
This fixes an issue with SkipRepeatsQueue._put() which causes it to raise an AttributeError on the first put. This is done by adding a check to test if _last_item is set to None, which is the value set by __init__()
|
I have added a test to check for this to the commit. |
|
Thanks @AndreiB97 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with
SkipRepeatsQueue._put()which causes it to raisean
AttributeErroron the first put. This is done by adding a check to testif
_last_itemis set toNone, which is the value set by__init__()Issue: #817