Fix test mocks for big endian systems #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, thanks @mgorny 💪 |
Done. |
BoboTiG
reviewed
Aug 19, 2021
BoboTiG
reviewed
Aug 19, 2021
mgorny
force-pushed
the
big-endian
branch
2 times, most recently
from
8722594 to
96e73e4
Compare
|
(Tests are failing because of the formatting.) |
|
Will fix it in a minute. |
Fix the mocked inotify data to respect system endianness. Instead of harcoding the raw data, reconstruct it using struct.pack(), respecting host endianness. This should also benefit readability a bit. Closes gorakhargosh#804
|
(updated) |
BoboTiG
approved these changes
Aug 19, 2021
|
That's great, thank you @mgorny ! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the mocked inotify data to respect system endianness. Instead of
harcoding the raw data, reconstruct it using struct.pack(), respecting
host endianness. This should also benefit readability a bit.