Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert regexes of type str to list #831

Merged
merged 2 commits into from
Aug 22, 2021
Merged

convert regexes of type str to list #831

merged 2 commits into from
Aug 22, 2021

Conversation

unique1o1
Copy link
Contributor

when type str is passed to the regexes argument, convert the str to a list and iterate through the list instead of iterating through str.

@BoboTiG
Copy link
Collaborator

BoboTiG commented Aug 22, 2021

Thanks @unique1o1 !

Could you add a test and a line in the changelog + your GitHub nickname?

@unique1o1
> tests added
2769292 
> updated changelog.rst
@unique1o1
Copy link
Contributor Author

Thanks @unique1o1 !

Could you add a test and a line in the changelog + your GitHub nickname?

Done.

@BoboTiG BoboTiG merged commit 75fe2d2 into gorakhargosh:master Aug 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unique1o1 @BoboTiG