fix: lint

goravel · Sep 4, 2024 · a82d4ac · a82d4ac
1 parent 7dfe6db
commit a82d4ac
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 13 deletions.
diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml
@@ -9,9 +9,7 @@ on:
     paths-ignore:
       - "**/*.md"
 permissions:
-  # contents permission to update benchmark data
   contents: write
-  # allow posting comments to pull request
   pull-requests: write
 jobs:
   benchmark:

diff --git a/.github/workflows/mockery.yml b/.github/workflows/mockery.yml
@@ -1,7 +1,9 @@
 name: Mockery
 on:
   pull_request:
-permissions: write-all
+permissions:
+  contents: write
+  pull-requests: write
 jobs:
   mockery:
     runs-on: ubuntu-latest

diff --git a/session/manager.go b/session/manager.go
@@ -31,7 +31,7 @@ func NewManager(config config.Config, json foundation.Json) *Manager {
 		},
 		},
 	}
-	manager.extendDefaultDriver()
+	manager.extendDefaultDrivers()
 	return manager
 }
 
@@ -91,9 +91,9 @@ func (m *Manager) getDefaultDriver() string {
 	return m.config.GetString("session.driver")
 }
 
-func (m *Manager) extendDefaultDriver() {
+func (m *Manager) extendDefaultDrivers() {
 	if _, err := m.Extend("file", m.createFileDriver); err != nil {
-		panic(fmt.Sprintf("failed to extend session manager: %v", err))
+		panic(fmt.Sprintf("failed to extend session file driver: %v", err))
 	}
 }
 

diff --git a/session/manager_test.go b/session/manager_test.go
@@ -2,7 +2,6 @@ package session
 
 import (
 	"fmt"
-	"github.com/goravel/framework/support/str"
 	"os"
 	"testing"
 
@@ -12,6 +11,7 @@ import (
 	sessioncontract "github.com/goravel/framework/contracts/session"
 	"github.com/goravel/framework/foundation/json"
 	mockconfig "github.com/goravel/framework/mocks/config"
+	"github.com/goravel/framework/support/str"
 )
 
 type ManagerTestSuite struct {
@@ -55,7 +55,7 @@ func (s *ManagerTestSuite) TestDriver() {
 
 	// provide custom driver
 	s.mockConfig.On("GetInt", "session.gc_interval", 30).Return(30).Once()
-	manager, err := s.manager.Extend("test", NewCustomDriver())
+	manager, err := s.manager.Extend("test", NewCustomDriver)
 	s.Nil(err)
 	s.NotNil(manager)
 	driver, err = s.manager.Driver("test")
@@ -80,7 +80,7 @@ func (s *ManagerTestSuite) TestDriver() {
 
 func (s *ManagerTestSuite) TestExtend() {
 	s.mockConfig.On("GetInt", "session.gc_interval", 30).Return(30).Once()
-	manager, err := s.manager.Extend("test", NewCustomDriver())
+	manager, err := s.manager.Extend("test", NewCustomDriver)
 	s.Nil(err)
 	s.NotNil(manager)
 	driver, err := s.manager.Driver("test")

diff --git a/support/file/file_test.go b/support/file/file_test.go
@@ -4,9 +4,9 @@ import (
 	"os"
 	"testing"
 
-	"github.com/goravel/framework/testing/file"
-
 	"github.com/stretchr/testify/assert"
+
+	"github.com/goravel/framework/testing/file"
 )
 
 func TestClientOriginalExtension(t *testing.T) {

diff --git a/validation/errors_test.go b/validation/errors_test.go
@@ -3,9 +3,9 @@ package validation
 import (
 	"testing"
 
-	httpvalidate "github.com/goravel/framework/contracts/validation"
-
 	"github.com/stretchr/testify/assert"
+
+	httpvalidate "github.com/goravel/framework/contracts/validation"
 )
 
 func TestOne(t *testing.T) {