Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add methods for migrate #174

Merged
merged 23 commits into from
Jun 10, 2023
Merged

feat: add methods for migrate #174

merged 23 commits into from
Jun 10, 2023

Conversation

devhaozi
Copy link
Member

Closes goravel/goravel#50

πŸ“‘ Description

Add refresh fresh reset status command for migrate.

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

none.

@devhaozi devhaozi requested a review from hwbrzzl June 10, 2023 10:19
@devhaozi devhaozi enabled auto-merge (squash) June 10, 2023 10:20
@codecov
Copy link

codecov bot commented Jun 10, 2023

Codecov Report

Patch coverage: 30.40% and project coverage change: -0.45 ⚠️

Comparison is base (86c2d6d) 61.11% compared to head (466d810) 60.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
- Coverage   61.11%   60.66%   -0.45%     
==========================================
  Files         116      120       +4     
  Lines        7362     7508     +146     
==========================================
+ Hits         4499     4555      +56     
- Misses       2558     2628      +70     
- Partials      305      325      +20     
Impacted Files Coverage Ξ”
database/console/migrate_command.go 30.00% <0.00%> (ΓΈ)
database/console/migrate_creator.go 54.54% <ΓΈ> (ΓΈ)
database/console/migrate_make_command.go 63.33% <ΓΈ> (ΓΈ)
database/console/migrate_rollback_command.go 23.91% <0.00%> (+23.91%) ⬆️
database/console/migrate_stubs.go 19.11% <ΓΈ> (ΓΈ)
database/console/table_guesser.go 93.75% <ΓΈ> (ΓΈ)
database/service_provider.go 0.00% <0.00%> (ΓΈ)
database/console/migrate_fresh_command.go 25.00% <25.00%> (ΓΈ)
database/console/migrate_refresh_command.go 25.71% <25.71%> (ΓΈ)
database/console/migrate_reset_command.go 30.00% <30.00%> (ΓΈ)
... and 1 more

β˜” View full report in Codecov by Sentry.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Just a few tips.

database/console/migrate_fresh_command.go Outdated Show resolved Hide resolved
database/console/migrate_fresh_command.go Show resolved Hide resolved
database/console/migrate_fresh_command.go Outdated Show resolved Hide resolved
database/console/migrate_refresh_command.go Outdated Show resolved Hide resolved
database/console/migrate_refresh_command.go Outdated Show resolved Hide resolved
database/console/migrate_status_command.go Outdated Show resolved Hide resolved
database/console/migrate_status_command.go Outdated Show resolved Hide resolved
database/console/migrate_status_command_test.go Outdated Show resolved Hide resolved
devhaozi and others added 12 commits June 10, 2023 19:27
Co-authored-by: Wenbo Han <hwbrzzl@gmail.com>
Co-authored-by: Wenbo Han <hwbrzzl@gmail.com>
Co-authored-by: Wenbo Han <hwbrzzl@gmail.com>
Co-authored-by: Wenbo Han <hwbrzzl@gmail.com>
Co-authored-by: Wenbo Han <hwbrzzl@gmail.com>
Co-authored-by: Wenbo Han <hwbrzzl@gmail.com>
Co-authored-by: Wenbo Han <hwbrzzl@gmail.com>
Co-authored-by: Wenbo Han <hwbrzzl@gmail.com>
Co-authored-by: Wenbo Han <hwbrzzl@gmail.com>
Co-authored-by: Wenbo Han <hwbrzzl@gmail.com>
@devhaozi devhaozi requested a review from hwbrzzl June 10, 2023 12:17
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devhaozi devhaozi merged commit 0f3793b into master Jun 10, 2023
@devhaozi devhaozi deleted the haozi/add-migrate branch June 10, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature] support migrate refresh, reset
2 participants