[Enhancement] Add Response Status #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwbrzzl
reviewed
Jun 23, 2023
http/gin_response.go
Outdated
| @@ -56,6 +56,10 @@ func (r *GinResponse) Success() httpcontract.ResponseSuccess { | |||
| return NewGinSuccess(r.instance) | |||
| } | |||
|
|
|||
| func (r *GinResponse) Status(code int) httpcontract.ResponseStatus { | |||
| return NewGinStatus(r.instance) | |||
There was a problem hiding this comment.
S: We need to set the code.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #209 +/- ##
==========================================
- Coverage 63.00% 62.93% -0.08%
==========================================
Files 125 125
Lines 8067 8077 +10
==========================================
Hits 5083 5083
- Misses 2636 2646 +10
Partials 348 348
β View full report in Codecov by Sentry. |
hwbrzzl
approved these changes
Jun 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
π Description
Add Status to response
β Checks
βΉ Additional Information