Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [#243] Optimize the return of controller #284

Merged
merged 12 commits into from
Sep 5, 2023

Conversation

hwbrzzl
Copy link
Contributor

@hwbrzzl hwbrzzl commented Sep 3, 2023

Closes goravel/goravel#243

πŸ“‘ Description

func (r *UserController) Show(ctx http.Context) http.Response {
	return ctx.Response().Success().Json(http.Json{
		"Hello": "Goravel",
	})
}

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Patch coverage is 90.00% of modified lines.

Files Changed Coverage
log/service_provider.go 0.00%
log/application.go 100.00%
log/logrus_writer.go 100.00%

πŸ“’ Thoughts on this report? Let us know!.

@hwbrzzl hwbrzzl requested a review from a team September 4, 2023 01:23
@hwbrzzl hwbrzzl merged commit 6548378 into master Sep 5, 2023
@hwbrzzl hwbrzzl deleted the bowen/optimize-response branch September 5, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature] Optimize the return of controller
3 participants