Revert "feat: [#507] Add Abort method for Response"

[hwbrzzl]

Reverts #776

The logic can be merged when gin and fiber are ready. Otherwise, will block other PRs.

Summary by CodeRabbit

• New Features

  • Updated response handling across various components to streamline the response types.
  • Introduced new test cases to verify logging behavior under specific conditions.

• Bug Fixes

  • Removed obsolete mock implementations for ResponseWithAbort and AbortResponse, simplifying the testing framework.

• Documentation

  • Enhanced clarity in method signatures to reflect updated response types.

• Tests

  • Modified test cases to align with the new response type expectations, ensuring consistent behavior in tests.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces significant changes to the HTTP response handling across multiple files. The primary modification is the removal of the ResponseWithAbort interface and the consolidation of response methods to return a standard Response type. This change affects contract interfaces, mock implementations, and test response structures in various packages. The modifications streamline the response handling by eliminating the abort functionality and simplifying the response type hierarchy.

Changes

File	Change Summary
contracts/http/response.go	Removed ResponseWithAbort interface, updated method signatures in ContextResponse and ResponseStatus interfaces to return Response
mocks/http/	Deleted AbortResponse.go and ResponseWithAbort.go, updated method signatures in ContextResponse.go and ResponseStatus.go to return Response
Test files	Updated TestResponse struct method signatures in multiple test files (throttle, logrus, session middleware) to return Response

Suggested reviewers

• devhaozi

Possibly related PRs

• feat: Add error return for the Call method of Artisan #687: Changes in error handling and response methods
• feat: [#441] Optimize the HTTP testing process [#1] #704: Enhancements to HTTP testing process
• feat: [#441] Add session to http testing [#5] #720: Session management in HTTP testing
• feat: [#280] Add Text, Json, etc methods #731: Modifications to data type handling
• feat: improve artisan migrate:status command #780: Improvements to command status output
• feat: [#473] ORM has its own logger instead of using facades.Log() #781: Introduction of dedicated ORM logger

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 375c494 and 57085e2.

📒 Files selected for processing (8)

• contracts/http/response.go (2 hunks)
• http/middleware/throttle_test.go (2 hunks)
• log/logrus_writer_test.go (2 hunks)
• mocks/http/AbortResponse.go (0 hunks)
• mocks/http/ContextResponse.go (11 hunks)
• mocks/http/ResponseStatus.go (6 hunks)
• mocks/http/ResponseWithAbort.go (0 hunks)
• session/middleware/start_session_test.go (2 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.73%. Comparing base (375c494) to head (57085e2).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #782   +/-   ##
=======================================
  Coverage   69.73%   69.73%           
=======================================
  Files         214      214           
  Lines       18357    18357           
=======================================
  Hits        12802    12802           
  Misses       4853     4853           
  Partials      702      702           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.