fix: [#515] bugs and add more tests

[hwbrzzl]

📑 Description

Closes goravel/goravel#515

Summary by CodeRabbit

• New Features

  • Enhanced handling of query parameters to prevent empty string issues in input arrays and maps.

• Bug Fixes

  • Improved logic for retrieving query parameters, ensuring more accurate data processing.

• Tests

  • Expanded test coverage for scenarios involving empty keys in both request bodies and query parameters.
  • Renamed existing tests for clarity and consistency.

✅ Checks

• Added test cases for my code

[coderabbitai]

Walkthrough

The changes involve modifications to the InputArray and InputMap methods in the ContextRequest struct within context_request.go. The InputArray method now includes a check for empty strings in query parameters, while the InputMap method's logic has been adjusted to retrieve query parameters differently. Corresponding updates were made to the test suite in context_request_test.go, including renaming existing tests and adding new tests to cover scenarios involving empty keys in both request bodies and query parameters.

Changes

File	Change Summary
context_request.go	- Updated InputArray: Added check for empty string in query parameter.
	- Updated InputMap: Changed logic for retrieving query parameters.
context_request_test.go	- Renamed TestInput_Empty to TestInput_KeyInBodyIsEmpty.
	- Added TestInput_KeyInQueryIsEmpty.
	- Renamed TestInputArray_Empty to TestInputArray_KeyInBodyIsEmpty.
	- Added TestInputArray_KeyInQueryIsEmpty.
	- Renamed TestInputMap_Empty to TestInputMap_KeyInBodyIsEmpty.
	- Added TestInputMap_KeyInQueryIsEmpty.

Assessment against linked issues

Objective	Addressed	Explanation
Support retrieval of data from query parameters in Input* methods (515)	✅

Possibly related PRs

• feat: [#515] Input* methods of http.Request support retrieve data from query and route #111: The changes in the InputArray and InputMap methods in the main PR are directly related to the modifications made in the same methods in PR feat: [#515] Input* methods of http.Request support retrieve data from query and route #111, which also focuses on enhancing the handling of query parameters and default values.

Suggested reviewers

• devhaozi

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. This feature will be included in our Pro Plan when released.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dce7445 and 39de1f7.

📒 Files selected for processing (2)

• context_request.go (2 hunks)
• context_request_test.go (6 hunks)

🔇 Additional comments (8)

context_request.go (2)

306-309: LGTM! Good defensive programming practice.

The added check properly handles the edge case where a query parameter contains a single empty string by returning an empty slice instead of [""]. This makes the behavior more intuitive and consistent.

---

329-330: LGTM! More precise query parameter handling.

The change improves the query parameter handling by first checking for the key's existence before retrieving the map. This is a more robust approach that better handles edge cases.

context_request_test.go (6)

Line range hint 652-671: LGTM! Clear and focused test case.

The test name change from TestInput_Empty to TestInput_KeyInBodyIsEmpty better describes the test's purpose. The test properly verifies that empty strings in the request body are preserved.

---

672-687: LGTM! Good test coverage for query parameters.

The new test case properly verifies the handling of empty query parameters, ensuring they return empty strings as expected. This complements the body test case and improves overall test coverage.

---

Line range hint 805-823: LGTM! Clear test for empty array handling in body.

The test name change from TestInputArray_Empty to TestInputArray_KeyInBodyIsEmpty better reflects its purpose. The test properly verifies that empty arrays in the request body return empty slices.

---

Line range hint 825-838: LGTM! Good test coverage for empty array query parameters.

The new test case verifies that empty array query parameters return empty slices, providing coverage for the fix implemented in InputArray. This ensures the edge case is properly handled.

---

Line range hint 932-952: LGTM! Clear test for empty map handling in body.

The test name change from TestInputMap_Empty to TestInputMap_KeyInBodyIsEmpty better reflects its purpose. The test properly verifies that empty maps in the request body return empty maps.

---

Line range hint 954-969: LGTM! Good test coverage for empty map query parameters.

The new test case verifies that empty map query parameters return empty maps, providing coverage for the improved query parameter handling in InputMap. This ensures the edge case is properly handled.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.