Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The cors middleware didn't work #12

Merged
merged 2 commits into from
Aug 27, 2023
Merged

fix: The cors middleware didn't work #12

merged 2 commits into from
Aug 27, 2023

Conversation

hwbrzzl
Copy link
Contributor

@hwbrzzl hwbrzzl commented Aug 26, 2023

Closes #

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 82.60% and project coverage change: -0.19% ⚠️

Comparison is base (63d411c) 77.07% compared to head (5dd9756) 76.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   77.07%   76.89%   -0.19%     
==========================================
  Files           9        9              
  Lines         711      714       +3     
==========================================
+ Hits          548      549       +1     
- Misses        133      135       +2     
  Partials       30       30              
Files Changed Coverage Ξ”
cors.go 84.44% <72.00%> (-2.52%) ⬇️
group.go 98.80% <94.73%> (+1.80%) ⬆️
route.go 90.00% <100.00%> (-0.33%) ⬇️

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Member

@devhaozi devhaozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cors.go Show resolved Hide resolved
cors.go Show resolved Hide resolved
@hwbrzzl hwbrzzl merged commit af1b746 into master Aug 27, 2023
@hwbrzzl hwbrzzl deleted the bowen/optimize-cors branch August 27, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants