Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support filter and optimize json #33

Merged
merged 8 commits into from
Nov 23, 2023
Merged

feat: support filter and optimize json #33

merged 8 commits into from
Nov 23, 2023

Conversation

devhaozi
Copy link
Member

@devhaozi devhaozi commented Nov 17, 2023

Closes goravel/goravel#304
Closes goravel/goravel#273
Closes goravel/goravel#259
Closes goravel/goravel#247
Closes goravel/goravel#313

📑 Description

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8cc8ecd) 77.75% compared to head (6801139) 79.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   77.75%   79.06%   +1.30%     
==========================================
  Files          12       12              
  Lines         863      874      +11     
==========================================
+ Hits          671      691      +20     
+ Misses        158      152       -6     
+ Partials       34       31       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

template.go Outdated Show resolved Hide resolved
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devhaozi devhaozi merged commit 4d85655 into master Nov 23, 2023
7 checks passed
@devhaozi devhaozi deleted the haozi/filter branch November 23, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment