-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: The HTTP module supports set Cookie #39
Conversation
@kkumar-gcc tests failed |
I think it will be fixed after merging this PR: goravel/framework#369. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #39 +/- ##
==========================================
+ Coverage 78.44% 78.72% +0.27%
==========================================
Files 12 12
Lines 863 879 +16
==========================================
+ Hits 677 692 +15
- Misses 154 155 +1
Partials 32 32 β View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic is good, please optimize the unit test. π
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job π
Closes #
π Description
β Checks
βΉ Additional Information