Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: The HTTP module supports set Cookie #39

Merged
merged 8 commits into from
Dec 16, 2023
Merged

Conversation

kkumar-gcc
Copy link
Member

Closes #

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

@kkumar-gcc kkumar-gcc requested a review from a team December 14, 2023 10:22
@devhaozi
Copy link
Member

@kkumar-gcc tests failed

@kkumar-gcc
Copy link
Member Author

kkumar-gcc commented Dec 14, 2023

@kkumar-gcc tests failed

I think it will be fixed after merging this PR: goravel/framework#369.
It couldn't find Cookie struct so it is failing.

@kkumar-gcc kkumar-gcc requested a review from devhaozi December 14, 2023 15:17
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (022f06a) 78.44% compared to head (793551a) 78.72%.

Files Patch % Lines
context_request.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   78.44%   78.72%   +0.27%     
==========================================
  Files          12       12              
  Lines         863      879      +16     
==========================================
+ Hits          677      692      +15     
- Misses        154      155       +1     
  Partials       32       32              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic is good, please optimize the unit test. πŸ‘

Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job πŸ‘

@kkumar-gcc kkumar-gcc merged commit 6d6dcf7 into master Dec 16, 2023
7 checks passed
@kkumar-gcc kkumar-gcc deleted the kkumar-gcc/#271 branch December 16, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants