Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Duplicate): Remove the logic of merge SlashForPath processing path #63

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

Joker-desire
Copy link
Contributor

@Joker-desire Joker-desire commented Jun 9, 2024

📑 Description

[Duplicate] Remove the logic of merge SlashForPath processing path

in gin github.com/gin-gonic/gin@v1.10.0/utils.go file:

func joinPaths(absolutePath, relativePath string) string {
	...

	finalPath := path.Join(absolutePath, relativePath) // The path will be formatted here
	...
	return finalPath
}

the path is processed,The mergeSlashForPath logic here is repeated, so it is removed.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@Joker-desire Joker-desire changed the title fix:[Duplicate] Remove the logic of merge SlashForPath processing path refactor:[Duplicate] Remove the logic of merge SlashForPath processing path Jun 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.30%. Comparing base (5a68f28) to head (d6194ae).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
+ Coverage   79.29%   81.30%   +2.01%     
==========================================
  Files          12       14       +2     
  Lines         874      781      -93     
==========================================
- Hits          693      635      -58     
+ Misses        151      117      -34     
+ Partials       30       29       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Joker-desire Joker-desire changed the title refactor:[Duplicate] Remove the logic of merge SlashForPath processing path refactor(Duplicate): Remove the logic of merge SlashForPath processing path Jun 10, 2024
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! thanks

@hwbrzzl hwbrzzl merged commit 356a2e7 into goravel:master Jun 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants