Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cookie MaxAge is incorrect #66

Merged
merged 5 commits into from
Jun 29, 2024
Merged

fix: cookie MaxAge is incorrect #66

merged 5 commits into from
Jun 29, 2024

Conversation

hwbrzzl
Copy link
Contributor

@hwbrzzl hwbrzzl commented Jun 28, 2024

πŸ“‘ Description

The MaxAge can't be set correctly, transform Expires to MaxAge.

βœ… Checks

  • Added test cases for my code

@hwbrzzl hwbrzzl force-pushed the bowen/fix-cookie branch from cbfa693 to 24a208b Compare June 28, 2024 13:07
Copy link
Member

@devhaozi devhaozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwbrzzl hwbrzzl merged commit 014b541 into master Jun 29, 2024
7 checks passed
@hwbrzzl hwbrzzl deleted the bowen/fix-cookie branch June 29, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants