fix: copy .env file error on Windows os. #9

jeff87218 · 2024-08-05T13:42:59Z

📑 Description

Replace the command with Go code for greater portability.
Closes goravel/goravel#461

@coderabbitai summary

✅ Checks

All the tests have passed

coderabbitai · 2024-08-05T13:43:06Z

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)

🚀 Review Ready

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

hwbrzzl · 2024-08-06T00:24:10Z

Thanks! Checking...

codecov-commenter · 2024-08-06T00:29:01Z

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

hwbrzzl

Great PR, thanks Bro! Could you optimize the existing test case like below?

hwbrzzl · 2024-08-06T09:19:47Z

console/commands/new_command.go

@@ -185,3 +186,23 @@ func (receiver *NewCommand) removeFiles(path string) error {
 	// Remove the .GitHub directory
 	return file.Remove(filepath.Join(path, ".github"))
 }
+
+func (receiver *NewCommand) copyFile(inputFilePath, outputFilePath string) (err error) {


Please add a test case for this function.

I have updated the unit tests. Please check them out.

hwbrzzl

Thanks! Two nitpicks.

hwbrzzl · 2024-08-06T13:52:35Z

console/commands/new_command_test.go

+	// Test copyFile
+	src := filepath.Join("example-app", ".env.example")
+	dst := filepath.Join("example-app", ".env")
+	assert.Nil(t, newCommand.copyFile(src, dst))
+	assert.True(t, file.Exists(dst))


This can be moved to a new function: TestCopyFile.

hwbrzzl · 2024-08-06T13:52:54Z

console/commands/new_command_test.go

@@ -47,6 +48,12 @@ func TestNewCommand(t *testing.T) {
 	assert.Contains(t, captureOutput, "App key generated successfully!")
 	assert.True(t, file.Exists("example-app"))


Suggested change

assert.True(t, file.Exists("example-app"))

assert.True(t, file.Exists("example-app"))

assert.True(t, file.Exists("example-app/.env"))

jeff87218 · 2024-08-06T16:39:57Z

Thanks! Two nitpicks.

I have updated the unit tests. Please check them out. Thank you for your review.

hwbrzzl · 2024-08-07T03:19:34Z

console/commands/new_command_test.go

+	assert.True(t, file.Exists(src))
+	assert.Nil(t, newCommand.copyFile(src, dst))
+	assert.True(t, file.Exists(dst))
+	assert.Nil(t, os.Remove(dst))


Please remove src, too.

hwbrzzl

Great PR, thanks for your contribution! will add you to the list. 👍

hwbrzzl · 2024-12-18T03:23:42Z

Hey @jeff87218 We created a private channel in Discord for contributors. You can click the link and DM me (@bowen) to join it if you are interested.

Here you can:

Send PR link or review others' PRs;
Discuss new features before creating an issue;
Vote for something;
etc.

fix: copy .env file error on Windows os.

0f72970

Merge branch 'master' into master

c0fc37b

chore: optimize code

cc6d20c

hwbrzzl reviewed Aug 6, 2024

View reviewed changes

jeff87218 added 2 commits August 6, 2024 20:31

feat: optimize test

72e1e08

Merge remote-tracking branch 'origin/master'

cb48cbc

hwbrzzl reviewed Aug 6, 2024

View reviewed changes

feat: optimize test

85ab3f3

hwbrzzl reviewed Aug 7, 2024

View reviewed changes

feat: optimize test

b4fa72d

hwbrzzl approved these changes Aug 7, 2024

View reviewed changes

hwbrzzl enabled auto-merge (squash) August 7, 2024 03:34

hwbrzzl merged commit 84bfaa1 into goravel:master Aug 7, 2024
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: copy .env file error on Windows os. #9

fix: copy .env file error on Windows os. #9

jeff87218 commented Aug 5, 2024 •

edited by hwbrzzl

Loading

coderabbitai bot commented Aug 5, 2024

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

hwbrzzl commented Aug 6, 2024

codecov-commenter commented Aug 6, 2024

hwbrzzl left a comment

hwbrzzl Aug 6, 2024

jeff87218 Aug 6, 2024

hwbrzzl left a comment

hwbrzzl Aug 6, 2024

hwbrzzl Aug 6, 2024

jeff87218 commented Aug 6, 2024

hwbrzzl Aug 7, 2024

jeff87218 Aug 7, 2024

hwbrzzl left a comment

hwbrzzl commented Dec 18, 2024

		@@ -47,6 +48,12 @@ func TestNewCommand(t *testing.T) {
		assert.Contains(t, captureOutput, "App key generated successfully!")
		assert.True(t, file.Exists("example-app"))

	assert.True(t, file.Exists("example-app"))
	assert.True(t, file.Exists("example-app"))
	assert.True(t, file.Exists("example-app/.env"))

fix: copy .env file error on Windows os. #9

fix: copy .env file error on Windows os. #9

Conversation

jeff87218 commented Aug 5, 2024 • edited by hwbrzzl Loading

📑 Description

✅ Checks

coderabbitai bot commented Aug 5, 2024

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

hwbrzzl commented Aug 6, 2024

codecov-commenter commented Aug 6, 2024

Welcome to Codecov 🎉

hwbrzzl left a comment

Choose a reason for hiding this comment

hwbrzzl Aug 6, 2024

Choose a reason for hiding this comment

jeff87218 Aug 6, 2024

Choose a reason for hiding this comment

hwbrzzl left a comment

Choose a reason for hiding this comment

hwbrzzl Aug 6, 2024

Choose a reason for hiding this comment

hwbrzzl Aug 6, 2024

Choose a reason for hiding this comment

jeff87218 commented Aug 6, 2024

hwbrzzl Aug 7, 2024

Choose a reason for hiding this comment

jeff87218 Aug 7, 2024

Choose a reason for hiding this comment

hwbrzzl left a comment

Choose a reason for hiding this comment

hwbrzzl commented Dec 18, 2024

jeff87218 commented Aug 5, 2024 •

edited by hwbrzzl

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)