improve phpdoc return type for apcu_cache_info #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was a bit confused by the Intellisense in VSCode since the
apcu_cache_infoseemed to return a boolean according to the doc comment, but when printing the results it was an array.It looks like the return value is consistent with the official documentation, so I figured it was a typo in the doc comment and changed the type from
booleantofalse | arrayin the ApcuProxy and CacheTool classes (no actual code was touched).I don't believe it affects anything beside intellisense, but I'm not sure how other IDE:s handle it.