Allow excluding files in opcache:status:scripts command #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dritter thanks for the contribution. Can you add a test case, both for when there's no exclusion and when there's exclusion? |
|
Uhm. This is harder than I thought. Is there a way to mock the data returned from OPcache? |
|
Okay. I added some tests. Not sure if this is the right way to add mock data. But now it is pretty easy to do so: Just add the mock data as second parameter to |
|
Looks good, thanks! |
gordalina
changed the title
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While inspecting our OPcache scripts, I noticed that most of them were some 3rd party scripts, which were mostly uninteresting for me. So I created an option to exclude some scripts from the listing.
You can now add
--exclude='/vendor/' to exclude all vendor scripts. Note, that this will match _all_ scripts that havevendor` in their path (there is no way to determine if the script is really a 3rd party script).The option takes a regex as value, so it would be possible to set
--exclude='.*dor/'to exclude all paths which have a directory ending with "dor/".Note: Delimiters are added automatically (I chose bracket style delimiters).