Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goreleaser-action downloads i386 version of installer on arm64 #297

Closed
tenyo opened this issue Aug 26, 2021 · 3 comments · Fixed by #299
Closed

goreleaser-action downloads i386 version of installer on arm64 #297

tenyo opened this issue Aug 26, 2021 · 3 comments · Fixed by #299
Labels
enhancement New feature or request

Comments

@tenyo
Copy link

tenyo commented Aug 26, 2021

I'm trying to use goreleaser on an arm64 self-hosted runner (Raspberry Pi 4) but it's downloading the i386 version (which subsequently fails to execute):

Run goreleaser/goreleaser-action@v2
  with:
    distribution: goreleaser
    version: v0.175.0
    args: release --rm-dist
    workdir: .
    install-only: false
  env:
    GOROOT: /tmp/actions-runner/_work/_tool/go/1.16.7/arm64
    GITHUB_TOKEN: ***
Downloading https://github.com/goreleaser/goreleaser/releases/download/v0.175.0/goreleaser_Linux_i386.tar.gz
Extracting GoReleaser

From my runner:

$ uname -m
aarch64

From my release.yml:

jobs:
  goreleaser:
    runs-on: ARM64
    steps:
      -
        name: Checkout
        uses: actions/checkout@v2
        with:
          fetch-depth: 0
      -
        name: Set up Go
        uses: actions/setup-go@v2
        with:
          go-version: 1.16
      -
        name: Run GoReleaser
        uses: goreleaser/goreleaser-action@v2
        with:
          distribution: goreleaser
          version: v0.175.0
          args: release --rm-dist
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@tenyo
Copy link
Author

tenyo commented Aug 26, 2021

I just looked quickly and the problem might be in https://github.com/goreleaser/goreleaser-action/blob/master/dist/index.js#L249 not checking for arm64

    const arch = osArch == 'x64' ? 'x86_64' : 'i386';

@crazy-max crazy-max added the enhancement New feature or request label Aug 26, 2021
@crazy-max
Copy link
Member

@tenyo Yes we can add a case for this platform.

@crazy-max
Copy link
Member

@tenyo You can try with uses: goreleaser/goreleaser-action@fix-platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants