-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: platform detection #299
Conversation
Codecov Report
@@ Coverage Diff @@
## master #299 +/- ##
=======================================
Coverage 85.86% 85.86%
=======================================
Files 4 4
Lines 92 92
Branches 17 17
=======================================
Hits 79 79
Misses 6 6
Partials 7 7
Continue to review full report at Codecov.
|
ede4161
to
28fe8ac
Compare
28fe8ac
to
b3eddb8
Compare
@crazy-max Thanks so much for the quick fix! I just tried it with |
@@ -47,7 +47,7 @@ export async function getGoReleaser(distribution: string, version: string): Prom | |||
|
|||
const getFilename = (distribution: string): string => { | |||
const platform: string = osPlat == 'win32' ? 'Windows' : osPlat == 'darwin' ? 'Darwin' : 'Linux'; | |||
const arch: string = osArch == 'x64' ? 'x86_64' : 'i386'; | |||
const arch: string = osArch == 'x64' ? 'x86_64' : 'x32' ? 'i386' : osArch; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be
const arch: string = osArch == 'x64' ? 'x86_64' : osArch == 'x32' ? 'i386' : osArch;
@@ -246,7 +246,7 @@ function getGoReleaser(distribution, version) { | |||
exports.getGoReleaser = getGoReleaser; | |||
const getFilename = (distribution) => { | |||
const platform = osPlat == 'win32' ? 'Windows' : osPlat == 'darwin' ? 'Darwin' : 'Linux'; | |||
const arch = osArch == 'x64' ? 'x86_64' : 'i386'; | |||
const arch = osArch == 'x64' ? 'x86_64' : true ? 'i386' : 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can see here it just evaluated the 'x32'
to true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh damn yes indeed :D
Fixes #297
cc @tenyo