Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

artifact signing #2

Merged
merged 1 commit into from
Sep 26, 2019
Merged

artifact signing #2

merged 1 commit into from
Sep 26, 2019

Conversation

gavincabbage
Copy link
Contributor

This PR adds a key input for use with GoReleaser's signing feature. The README and Action configuration are also updated accordingly.

When signing is enabled in the GoReleaser configuration, the key input can be populated with a gpg private key block which will be imported before running GoReleaser. The GoReleaser signs.args section should be modified to reference the key, e.g.

signs:
  - artifacts: checksum
    args: ["--batch", "-u", "<key id, fingerprint, email, ...>", "--output", "${signature}", "--detach-sign", "${artifact}"]

This is currently only compatible when using the default gpg command and a private key without a passphrase. Also, only a single public key is supported.

I'm new to TypeScript and also haven't used GPG in a few years so feedback is very welcome. This was the bare minimum to get signing working for a project of mine, but has a lot of caveats as described above.

Thanks for putting this together!

Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little change but this is awesome! Thanks @gavincabbage!

README.md Outdated Show resolved Hide resolved
@gavincabbage
Copy link
Contributor Author

Got that fixed for you!

@crazy-max crazy-max merged commit be0c568 into goreleaser:master Sep 26, 2019
@crazy-max
Copy link
Member

Thanks again 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants